Pass site or siteId to @netlify/config #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
reviewed
Jul 20, 2020
src/utils/command.js
Outdated
| try { | ||
| return await resolveConfig({ | ||
| config: argv.config, | ||
| cwd: cwd, | ||
| context: argv.context, | ||
| debug: argv.debug, | ||
| siteId: state.get('siteId'), | ||
| siteId: argv.siteId || typeof argv.site === 'string' && argv.site || state.get('siteId'), |
There was a problem hiding this comment.
Do we have any CLI flag called siteId instead of site?
There was a problem hiding this comment.
Yes, we have a site flag in netlify deploy
There was a problem hiding this comment.
We have a site CLI flag in other commands as well. What about a siteId CLI flag?
There was a problem hiding this comment.
The other site flag is a boolean. That's why I'm checking for typeof. We're checking for both siteId and a string site flag now.
There was a problem hiding this comment.
I am wondering if argv.siteId || could be removed since we don't have any siteId CLI flag at the moment?
ehmicky
approved these changes
Jul 20, 2020
|
CI tests seem to be failing due to linting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Fixes: #959
- Test plan
- Description for the changelog
Use
siteIdorsiteflags assiteIdas parameters toresolveConfig- A picture of a cute animal (not mandatory but encouraged)
🐠